Paralysis By Options Do you ever find yourself in a situation where some API or another requires you to instantiate an object? (If you’re reading this blog, the answer is probably “yes”). What do you usually do at this point? Instantiate it, compile, and make sure you’re good before poking around to see what your…
Copy, Paste, Fail, Repeat Today, I was reviewing some code, and I saw a “before” that looked like this: private void RefreshClassifierValues(Array NewValues) { List ClassifiersList = Classifiers; int i = 0; foreach (Classifier classifier in ClassifiersList) { classifier.Value = NewValues.GetValue(i++); } } The first thing that stuck out to me was that I really…
What’s a Bloated Constructor? Yesterday, I was going through the version history of a file in some code base (from earliest to most recent) and I saw the following: public ActiveProduct(Product product, StringVersion driver, Side es) { Side = es; try { if (product == null) throw new Exception(“Can’t create an active product from a…
Learning to Love Bugs My apologies for the titular pun in reference to “I Love Big Brother” of iconic, Orwellian fame, but I couldn’t resist. The other day, I was chatting with some people about the idea of factoring large methods into smaller, more focused ones and one of the people chimed in with an…
I was helping someone troubleshoot an issue today, digging through code, and I came across a double-take-inducing design decision. In the GUI, there was a concept of feature, and each feature was being bound to something called FeatureGroup which was a collection of features that, at run-time, only ever contained one feature. So, as a…
