Stories about Software


Chess TDD 40: Diagonal Capture for Pawns

This post was the last of a series of 3 I recorded together, so it picks up right on the heels of episode 39 from a flow perspective.  I initially tied up loose ends from the previous episode and then got the pawn’s diagonal capture in place, at least for the white pawns (acceptance tests for black pawns won’t go well right now).  Fits and starts, but real progress nonetheless.

What I accomplish in this clip:

  • Finished the TDD implementation for IsCaptureAllowed
  • Implemented IsNonCaptureAllowed
  • Finally gave pawn diagonal capture ability

Here are some lessons to take away:

  • Always look to refactor test code when it comes to readability and eliminating duplication.  These refactorings are not just for production code!
  • There’s a sizable contingent of people that don’t like seeing the Assert call factored out of unit tests.  Clearly a matter of personal preference, but you may get pushback in a shared code base.
  • In methods, preserve a consistent level of abstraction.  If you have complex two part conditional, don’t factor out one part and leave the other part — make them both conceptually similar.
  • Clean, readable code will look at least vaguely familiar to domain experts, even if they aren’t programmers.  They should see/read concepts that are familiar.
  • Keeping the lines of code low in a class isn’t a first class or all-encompassing goal.  A class can get ugly by having too many methods, even if all of those methods are small.

Newest Most Voted
Inline Feedbacks
View all comments
Colin Higgins
8 years ago

Erik, I just want to thank you for your posts on your chess application. I had been working on mine as a learning project for a long time and your series has inspired me to go back to it and actually work through and write all of the tests. I will probably do a full refactor and start to implement what is needed for the AI as well. I am going to go through your series again and see if I can steal any snippets. If you have time at any point I would much appreciate a conversation or review… Read more »

Erik Dietrich
8 years ago
Reply to  Colin Higgins

Hey, thanks for the feedback, and I’m happy to chat. I am out of the country this week, though, with a pretty spotty internet connection. Maybe ping me next week sometime, when I’m home…?

Colin Higgins
8 years ago
Reply to  Erik Dietrich

Will do, I’m in the mountains at the moment myself, I think a bear is chewing on my internet.